🌱 csctl accepts "--node-image-registry" now #105
Merged
Merged
Conversation
…ugin. Signed-off-by: Thomas Guettler <[email protected]>
07615fa to
15875c2
Compare
Contributor
michal-gubricky
left a comment
There was a problem hiding this comment.
I tested it with the docker example plugin and it works. I also plan to use this feature in openstack plugin to give the creator of the cluster-stacks option to provide path to registry.yaml where will be stored credentials to the S3 bucket to be able to push built image to S3.
3 tasks
michal-gubricky
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csctl accepts "--node-image-registry" now and passes it to the plugin.
Example:
What this PR does / why we need it:
For building node images the plugin needs to know the oci-registry.
The patch makes csctl accept the --node-image-registry flag. It gets passed to the plugin, too.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #100
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: