Skip to content

Refactor PKCS#11 RSA mechanism handling for sign and decrypt operations#656

Merged
mtrojnar merged 2 commits into
OpenSC:masterfrom
olszomal:rsa_mechanizm
May 28, 2026
Merged

Refactor PKCS#11 RSA mechanism handling for sign and decrypt operations#656
mtrojnar merged 2 commits into
OpenSC:masterfrom
olszomal:rsa_mechanizm

Conversation

@olszomal
Copy link
Copy Markdown
Collaborator

Pull Request Type

  • Bug fix
  • New feature
  • Code style / formatting / renaming
  • Refactoring (no functional or API changes)
  • Build / CI related changes
  • Documentation
  • Other (please describe):

Related Issue

Issue number: N/A

Current Behavior

RSA signing and decryption shared a single PKCS#11 mechanism setup helper, mixing unrelated logic and requiring unused parameters in decrypt paths.

New Behavior

  • split PKCS#11 RSA mechanism setup into separate helpers for signing and decryption.
  • RSA tests now automatically skip unsupported PKCS#11 mechanisms.

Scope of Changes

  • split RSA mechanism setup helpers
  • updated internal callers and comments
  • no intended functional changes

Testing

  • Existing tests
  • New tests added
  • Manual testing

Additional Notes

License Declaration

  • I hereby agree to license my contribution under the project's license.

@mtrojnar mtrojnar merged commit 6ceb2c0 into OpenSC:master May 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants