Validate that trigger configurations must include a file pattern.#7702
Open
labkey-klum wants to merge 5 commits into
Open
Validate that trigger configurations must include a file pattern.#7702labkey-klum wants to merge 5 commits into
labkey-klum wants to merge 5 commits into
Conversation
… could result in orphaned listeners. Add unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
related issue: https://github.com/LabKey/internal-issues/issues/1093
The current pipeline trigger UI will allow the creation of a trigger with a blank file regex. This is bad because it results in a configuration that matches anything in the watched location(s). This includes artifacts generated by the pipeline tasks such as .log files and pipeline protocol information stored in the
.labkeysystem directory. When this happens the configuration will continue to trigger itself endlessly and fill up the quiet period queue with jobs for each newly created file.The only way to stop this is to disable or delete the trigger, but then the in-memory queue will continue to add new pipeline jobs until it is eventually drained (unless the server is restarted prior to that).
Related Pull Requests
Changes
Mark the file pattern field as required for pipeline trigger configurations. Also add a server side check.