Restructure Python examples#2292
Merged
Merged
Conversation
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
coverage: 75.39%. remained the same — restructure-python-examples into master |
ndgrigorian
force-pushed
the
restructure-python-examples
branch
from
88b3bd6 to
2060c9d
Compare
as some devices (especially those in GH runners) cannot be partitioned into sub-devices, we print that the device cannot be partitioned and discard the exception
ndgrigorian
force-pushed
the
restructure-python-examples
branch
from
2060c9d to
23cf073
Compare
vlad-perevezentsev
previously approved these changes
May 26, 2026
Collaborator
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @ndgrigorian
Just a few minor comments below:
ndgrigorian
force-pushed
the
restructure-python-examples
branch
from
186df70 to
ec1a5ea
Compare
vlad-perevezentsev
approved these changes
May 26, 2026
Collaborator
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thanks @ndgrigorian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a restructuring of the Python examples, specifically the USM-related examples
These examples were each very simple scripts, all relating to various operations with USM: allocation, host-access, and copying between host and device. By consolidating them, they can be run using the same
_runnerconstruct as the other examples.As a result of this, the Conda package workflow's run of examples is updated to use the
runnerconstruct. This also means that all of the examples are being run, instead of just the USM examples.