Skip to content

Replace flake8 and black with ruff#14271

Open
mattiagiupponi wants to merge 2 commits into
masterfrom
ruff
Open

Replace flake8 and black with ruff#14271
mattiagiupponi wants to merge 2 commits into
masterfrom
ruff

Conversation

@mattiagiupponi
Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 27, 2026
Comment thread geonode/geoserver/helpers.py Fixed
Comment thread geonode/geoserver/helpers.py Fixed
Comment thread geonode/geoserver/helpers.py Fixed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a large-scale code formatting and import sorting cleanup across various modules of the GeoNode codebase, including base, layers, maps, documents, and harvesting. The review feedback highlights several minor issues resulting from collapsing multi-line implicitly concatenated strings into single lines, which caused missing spaces (such as 'bedeprecated', 'at least{min_digits}', and run-together log messages). Additionally, the reviewer pointed out a spelling typo ('asyncronous') and a duplicate word ('size size') in a document upload form error message along with its corresponding test. All of these comments are highly actionable and include precise code suggestions.

Comment thread geonode/base/views.py Outdated
Comment thread geonode/context_processors.py Outdated
Comment thread geonode/documents/forms.py Outdated
Comment thread geonode/documents/tests.py Outdated
Comment thread geonode/harvesting/tasks.py Outdated
Comment thread geonode/geoserver/helpers.py Outdated
Comment thread geonode/people/password_validators.py Outdated
Comment thread geonode/people/password_validators.py Outdated
Comment thread geonode/people/adapters.py Fixed
Comment thread geonode/views.py Fixed
Comment thread geonode/api/views.py Fixed
Comment thread geonode/proxy/views.py Fixed
Comment thread geonode/security/views.py Fixed
Comment thread geonode/upload/handlers/xlsx/handler.py Fixed
Comment thread geonode/upload/handlers/xml/handler.py Fixed
Comment thread geonode/views.py Fixed
Comment thread pavement.py Dismissed
Comment thread tests/pavement.py Dismissed
@mattiagiupponi
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily applies extensive code formatting and style updates across the codebase to improve readability and consistency. Feedback on the changes highlights several critical issues: an invalid import path referencing the 'build/' directory in 'geonode/harvesting/harvesters/base.py', a logical bug in test assertions within 'geonode/base/tests.py' where multiple string memberships were incorrectly evaluated using 'and', and a security vulnerability in 'create-envfile.py' where 'random.choice' was used instead of a cryptographically secure random generator for creating the Django 'SECRET_KEY'.

Comment thread geonode/harvesting/harvesters/base.py Outdated
Comment thread geonode/base/tests.py Outdated
Comment thread geonode/base/tests.py Outdated
Comment thread create-envfile.py Outdated
@mattiagiupponi mattiagiupponi marked this pull request as ready for review May 29, 2026 14:03
@mattiagiupponi mattiagiupponi requested review from etj and giohappy May 29, 2026 14:03
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.82%. Comparing base (91c4ec5) to head (7889922).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14271      +/-   ##
==========================================
- Coverage   74.92%   74.82%   -0.11%     
==========================================
  Files         975      977       +2     
  Lines       59902    60063     +161     
  Branches     8157     8186      +29     
==========================================
+ Hits        44884    44944      +60     
- Misses      13194    13295     +101     
  Partials     1824     1824              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants