Replace flake8 and black with ruff#14271
Conversation
There was a problem hiding this comment.
Code Review
This pull request performs a large-scale code formatting and import sorting cleanup across various modules of the GeoNode codebase, including base, layers, maps, documents, and harvesting. The review feedback highlights several minor issues resulting from collapsing multi-line implicitly concatenated strings into single lines, which caused missing spaces (such as 'bedeprecated', 'at least{min_digits}', and run-together log messages). Additionally, the reviewer pointed out a spelling typo ('asyncronous') and a duplicate word ('size size') in a document upload form error message along with its corresponding test. All of these comments are highly actionable and include precise code suggestions.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request primarily applies extensive code formatting and style updates across the codebase to improve readability and consistency. Feedback on the changes highlights several critical issues: an invalid import path referencing the 'build/' directory in 'geonode/harvesting/harvesters/base.py', a logical bug in test assertions within 'geonode/base/tests.py' where multiple string memberships were incorrectly evaluated using 'and', and a security vulnerability in 'create-envfile.py' where 'random.choice' was used instead of a cryptographically secure random generator for creating the Django 'SECRET_KEY'.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14271 +/- ##
==========================================
- Coverage 74.92% 74.82% -0.11%
==========================================
Files 975 977 +2
Lines 59902 60063 +161
Branches 8157 8186 +29
==========================================
+ Hits 44884 44944 +60
- Misses 13194 13295 +101
Partials 1824 1824 🚀 New features to boost your workflow:
|
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.