Fixes issue #262 - Prevented crash when removing lint_off option.#352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #262 - eSim crashes while using Remove lint_off option
Purpose
Resolved a runtime crash that occurs when attempting to remove a lint warning entry via the Remove lint_off dropdown in the NgVeri tab. The issue arises when the selected entry does not match any exact line in the lint_off.txt file due to inconsistent line endings or formatting.
Approach
Modifies the lint_off_edit() function in NgVeri.py to handle (list.remove(x): x not in list) error when removing entries from lint_off.txt. The updated logic uses a try-except block to catch exceptions such as file access errors or missing entries. Instead of crashing the application, a warning message is displayed to the user if the operation fails. Makes the removal process safe and prevents GUI crashes.