feat: support custom command and args for container#222
Open
QSummerY wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 84a2a43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the limitation where users cannot override the container's default entrypoint and arguments via Helm values.
Problem
Currently, the Deployment template hardcodes or relies entirely on the Docker image's built-in
ENTRYPOINTandCMD. In enterprise or debugging scenarios (as reported in hyperdxio/hyperdx#1329), users frequently need to pass custom flags, inject debugging tools, or alter the container startup behavior. Withoutcommandandargssupport invalues.yaml, this is impossible without fracturing the chart or maintaining a custom fork.Backward Compatibility
This change is 100% backward compatible and introduces zero breaking changes for existing deployments due to the following safeguards:
values.yaml, bothcommandandargsare initialized as empty lists ([]).deployment.yaml, we use Helm's{{- if ... }}blocks. If a user upgrades their existing release without providing these values, the template simply skips rendering the fields entirely. The container will continue to fall back to the image's original behavior exactly as before.