fix: convert __NONE__ project placeholder to empty string#378
Merged
its-me-abhishek merged 1 commit intoJan 7, 2026
Merged
Conversation
- Fixes bug where selecting "No project" stored "__NONE__" instead of empty string. Added unit test for this edge case. - Fixes: CCExtractor#377
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
ShivaGupta-14
commented
Jan 6, 2026
Author
There was a problem hiding this comment.
converts NONE to empty string when "No project" is selected
ShivaGupta-14
commented
Jan 6, 2026
ShivaGupta-14
commented
Jan 6, 2026
Author
ShivaGupta-14
left a comment
There was a problem hiding this comment.
self review done! ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where selecting "No project" stored "NONE" instead of empty string. Added unit test for this edge case.
Fixes: Selecting No project as Project on Add Task adds a __None__ value by default #377
Additional Bug Found
While testing this fix, I discovered a related crash bug:
Steps to reproduce (before fix):
Video:
Before:
Screen.Recording.2026-01-06.at.7.05.30.PM.mov
After:
Screen.Recording.2026-01-06.at.7.10.31.PM.mov
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes