Avoid std::map in EventSelectionModule#16396
Conversation
ktf
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene and
jgrosseo
as code owners
|
@ddobrigk can you have a look here? Looking up in a map is very expensive due to the pointer traversal and constructing it requires one allocation per node which is also expensive. A binary search in a vector of pairs should be much faster. Also, @aalkin was suggesting to use a index table for this? |
|
@ekryshen can you have a look at this? |
|
@ktf Thanks, looks reasonable. Actually I suspect that we don't need this map or vector of pairs any longer. It was introduced as a workaround for early passes of pp2022 where trigger info wasn't aligned with actual bcs. As far as I understand, the trigger functionality is used by EMCAL analysers only. I will check with them if they still need support of old passes. If not, we can simply remove this workaround. |
|
@ktf I've just got a confirmation that early passes are not used by ECAL analysers so this functionality is not needed any longer. How should we proceed? We can either merge or close this PR, then I will clean up this code. |
|
removing the mapping completely is of course fine with me. can you take care of it? |
2 participants
No description provided.