[PWGJE] New code for hadronjet correlations of Jan Janis by fkrizek · Pull Request #16387 · AliceO2Group/O2Physics

fkrizek · 2026-05-26T08:42:10Z

This is a code of Jan Janis who is undergrad student of Filip Krizek. Jan will use this code to study hadron jet correlations.

github-actions · 2026-05-26T08:42:30Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild · 2026-05-26T08:49:14Z

Error while checking build/O2Physics/staging for e4c372b at 2026-05-26 10:49:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:510:30: error: 'JTracksTable' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:511:30: error: 'JetsBase' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:512:30: error: 'JetsTag' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:221:103: error: 'setSumw2' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:518:31: error: there are no arguments to 'begin' that depend on a template parameter, so a declaration of 'begin' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:518:31: error: there are no arguments to 'end' that depend on a template parameter, so a declaration of 'end' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:522:31: error: 'trackPt' was not declared in this scope; did you mean 'track'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:528:17: error: capture of non-variable 'TrackJetSpectra::rand'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:528:21: error: expected ',' before '->' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:528:21: error: expected identifier before '->' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:528:51: error: expected '{' before ';' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:530:32: error: there are no arguments to 'begin' that depend on a template parameter, so a declaration of 'begin' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:530:32: error: there are no arguments to 'end' that depend on a template parameter, so a declaration of 'end' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:779:26: error: no matching function for call to 'TrackJetSpectra::fillMatchedHistograms(const FilteredTracks&, o2::soa::Filtered<o2::soa::Join<o2::soa::Table<o2::aod::Hash<2798090592>, o2::aod::Hash<100195879>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<198532478>, o2::aod::Hash<3712200270>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4034896057>, o2::aod::Hash<419444554>, o2::aod::Hash<2286545062> > > >&, const FilteredMatchedJetsDetLevel&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:806:33: error: 'maxJetConstituentPt' was not declared in this scope; did you mean 'jetConstituent'?
ninja: build stopped: subcommand failed.

Full log here.

[PWGJE] Please consider the following formatting changes to AliceO2Group#16387

alibuild · 2026-05-26T08:52:20Z

Error while checking build/O2Physics/o2 for e4c372b at 2026-05-26 10:52:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:510:30: error: 'JTracksTable' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:511:30: error: 'JetsBase' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:512:30: error: 'JetsTag' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:221:103: error: 'setSumw2' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:518:31: error: there are no arguments to 'begin' that depend on a template parameter, so a declaration of 'begin' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:518:31: error: there are no arguments to 'end' that depend on a template parameter, so a declaration of 'end' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:522:31: error: 'trackPt' was not declared in this scope; did you mean 'track'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:528:17: error: capture of non-variable 'TrackJetSpectra::rand'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:528:21: error: expected ',' before '->' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:528:21: error: expected identifier before '->' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:528:51: error: expected '{' before ';' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:530:32: error: there are no arguments to 'begin' that depend on a template parameter, so a declaration of 'begin' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:530:32: error: there are no arguments to 'end' that depend on a template parameter, so a declaration of 'end' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:779:26: error: no matching function for call to 'TrackJetSpectra::fillMatchedHistograms(const FilteredTracks&, o2::soa::Filtered<o2::soa::Join<o2::soa::Table<o2::aod::Hash<2798090592>, o2::aod::Hash<100195879>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<198532478>, o2::aod::Hash<3712200270>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4034896057>, o2::aod::Hash<419444554>, o2::aod::Hash<2286545062> > > >&, const FilteredMatchedJetsDetLevel&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/trackJetSpectra.cxx:806:33: error: 'maxJetConstituentPt' was not declared in this scope; did you mean 'jetConstituent'?
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2026-05-26T08:54:02Z

Please test the code properly before opening the PR for review.

vkucera · 2026-05-26T11:30:16Z

Please restore the commit history of this PR and reopen it.

[PWGJE] Please consider the following formatting changes to AliceO2Group#16387

nzardosh · 2026-05-29T22:31:30Z

+#include "Common/DataModel/Multiplicity.h"
+
+#include <CommonConstants/MathConstants.h>
+#include <Framework/ASoA.h>


Could you please check if all these includes are needed? They were recently cleaned up so you could discuss with vit if these are an updated list

nzardosh · 2026-05-29T22:33:13Z

+
+using FilteredCollPartLevelMB = soa::Filtered<soa::Join<aod::JetMcCollisions, aod::BkgChargedMcRhos>>::iterator;
+
+using CollPartLevelMBEfficiency = aod::JetMcCollisions::iterator;


for places where these are only used once you can directly use the table instead of this alias

nzardosh · 2026-05-29T22:34:58Z

+using namespace o2::framework::expressions;
+
+using FilteredColl = soa::Filtered<soa::Join<aod::JetCollisions, aod::BkgChargedRhos>>::iterator;
+using FilteredEventMultiplicity = soa::Filtered<soa::Join<aod::JetCollisions, aod::ZDCMults>>::iterator;


the ZDCMult table would not allow you to use the JE derived data. is the information needed?

nzardosh · 2026-05-29T22:35:52Z

+
+using FilteredTracksMatch = soa::Filtered<soa::Join<aod::JetTracks, aod::McTrackLabels>>;
+
+using ParticlesFullTable = soa::Join<aod::JetParticles, aod::JMcParticlePIs>;


you should remove the PIs tables evrywhere since you dont actually access the original tables

nzardosh · 2026-05-29T22:36:22Z

+
+    auto mcpjetsPerMCCollision = mcpjets.sliceBy(partJetsPerCollision, collision.mcCollisionId());
+
+    fillMatchedHistograms(tracks, mcpjetsPerMCCollision, mcdjets);


does this not need a weight?

nzardosh · 2026-05-29T22:42:59Z

+          float detJetPt = jetMatched.pt();
+
+          spectra.fill(HIST("hJetPt_resolution"), (partJetPt - detJetPt) / partJetPt, partJetPt, weight);
+          spectra.fill(HIST("hJetPhi_resolution"), partJet.phi() - jetMatched.phi(), partJetPt, weight);


you are not wrapping phi. You should use the constrainAngle function in recodecay

nzardosh · 2026-05-29T22:43:51Z

+        continue;
+
+      auto collTracks = tracks.sliceBy(tracksPerJCollision, collision.globalIndex());
+      spectra.fill(HIST("hNTracksPerCollision"), collTracks.size());


does this need a weight?

nzardosh · 2026-05-29T22:45:22Z

+    while (bCloseJet) {
+      iii++;
+      if (iii > maxRandomConeIterations) {
+        break;


if this loop breaks previous values of randJetPhi are still used in line 495

nzardosh · 2026-05-29T22:45:48Z

+      }
+
+      randJetPhi = rand.Uniform(-constants::math::PI, constants::math::PI);
+      randJetEta = rand.Uniform(-0.5, 0.5);


should it be a configurable?

nzardosh · 2026-05-29T22:46:38Z

+
+      // Z coordinate of collision vertex
+      spectra.add("hVertexZ_NoCut", "z vertex of collisions w/o cut", kTH1F, {{100, -20., 20., "#it{z}_{vertex}"}});
+      spectra.add("hVertexZ_Cut", "z vertex of collisions w. cut", kTH1F, {{100, -20., 20., "#it{z}_{vertex}"}});


some histograms like this are never filled

New code for hadronjet correlations of Jan Janis

e4c372b

fkrizek requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern, nzardosh and raymondEhlers as code owners May 26, 2026 08:42

github-actions Bot added the pwgje label May 26, 2026

github-actions Bot changed the title ~~New code for hadronjet correlations of Jan Janis~~ [PWGJE] New code for hadronjet correlations of Jan Janis May 26, 2026

Please consider the following formatting changes

9c562b6

alibuild mentioned this pull request May 26, 2026

[PWGJE] Please consider the following formatting changes to #16387 fkrizek/O2Physics#28

Merged

Merge pull request #28 from alibuild/alibot-cleanup-16387

8d42b01

[PWGJE] Please consider the following formatting changes to AliceO2Group#16387

vkucera marked this pull request as draft May 26, 2026 08:53

vkucera reviewed May 26, 2026

View reviewed changes