Skip to content

fix[backend](visualizations): removed utm-geoip legacy index referenc…#2098

Merged
osmontero merged 2 commits into
release/v11.2.9from
backlog/fix/geoip
May 22, 2026
Merged

fix[backend](visualizations): removed utm-geoip legacy index referenc…#2098
osmontero merged 2 commits into
release/v11.2.9from
backlog/fix/geoip

Conversation

@AlexSanchez-bit
Copy link
Copy Markdown
Contributor

No description provided.

@AlexSanchez-bit AlexSanchez-bit requested a review from a team May 22, 2026 16:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

❌ Go dependencies check failed

There are outdated Go dependencies, or modules that could not be inspected.
Run bash .github/scripts/go-deps.sh --update --discover locally and
commit the updated go.mod / go.sum files.

Script output
🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./agent:
     - golang.org/x/sys: v0.44.0 → v0.45.0

�[0;31m❌ Please update dependencies before merging.�[0m

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

⚠️ AI review — Changes requested

One or more prompts found issues the author should fix before merging. Details below.

⚠️ architecture (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Refactored coordinate map geolocation from a dedicated IP lookup service to direct OpenSearch top_hits aggregation.

  • medium backend/src/main/java/com/park/utmstack/util/chart_builder/elasticsearch_dsl/responses/impl/coordinate_map/ResponseParserForCoordinateMapChart.java:135 — Hardcoded geolocation field paths (origin, source, destination) in the parser. Consider moving these to a shared configuration or constant to ensure consistency across other visualization parsers.
  • low backend/src/main/resources/config/application-prod.yml:64 — Removed ip-info-index-name configuration. Ensure that no other legacy services or external scripts still rely on this index configuration.

⚠️ bugs (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Removed IpInfoService dependency but left a potential runtime risk in extractLatLongFromRow due to non-deterministic map iteration.

  • medium backend/src/main/java/com/park/utmstack/util/chart_builder/elasticsearch_dsl/responses/impl/coordinate_map/ResponseParserForCoordinateMapChart.java:135 — The method extractLatLongFromRow iterates over a Map (row.entrySet()) to find latitude and longitude. Since Map iteration order is not guaranteed, if a row contains multiple geolocation fields (e.g., source and destination), the code may pair a latitude from one field with a longitude from another, leading to incorrect coordinate data.

security (gemini-3-flash-lite) — Tier 1 — looks clean

Summary: Refactoring of GeoIP lookup logic from external service calls to direct OpenSearch aggregation; no security vulnerabilities introduced.

No findings.

Copy link
Copy Markdown

@utmstackprapprover utmstackprapprover Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

@osmontero osmontero enabled auto-merge (squash) May 22, 2026 18:19
Copy link
Copy Markdown

@utmstackprapprover utmstackprapprover Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

@osmontero osmontero disabled auto-merge May 22, 2026 18:22
@osmontero osmontero merged commit 8849f1b into release/v11.2.9 May 22, 2026
5 of 7 checks passed
@osmontero osmontero deleted the backlog/fix/geoip branch May 22, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants