Skip to content

Remove use of pp in DifferDispatcher#242

Merged
mcmire merged 1 commit into
splitwise:mainfrom
sidane:remove-call-to-pp-in-differ-dispatcher
Apr 25, 2024
Merged

Remove use of pp in DifferDispatcher#242
mcmire merged 1 commit into
splitwise:mainfrom
sidane:remove-call-to-pp-in-differ-dispatcher

Conversation

@sidane
Copy link
Copy Markdown
Contributor

@sidane sidane commented Apr 25, 2024

Was causing the following output when running tests in Rails app using super_diff:

{:available_classes=>
  [SuperDiff::ActiveRecord::Differs::ActiveRecordRelation,
   SuperDiff::ActiveSupport::Differs::HashWithIndifferentAccess,
   SuperDiff::RSpec::Differs::CollectionContainingExactly,
   SuperDiff::RSpec::Differs::CollectionIncluding,
   SuperDiff::RSpec::Differs::HashIncluding,
   SuperDiff::RSpec::Differs::ObjectHavingAttributes,
   SuperDiff::Basic::Differs::Array,
   SuperDiff::Basic::Differs::Hash,
   SuperDiff::Basic::Differs::TimeLike,
   SuperDiff::Basic::Differs::DateLike,
   SuperDiff::Basic::Differs::MultilineString,
   SuperDiff::Basic::Differs::CustomObject,
   SuperDiff::Basic::Differs::DefaultObject]}

available_classes_output

Was causing the following output when running tests in Rails app
using super_diff:

```
{:available_classes=>
  [SuperDiff::ActiveRecord::Differs::ActiveRecordRelation,
   SuperDiff::ActiveSupport::Differs::HashWithIndifferentAccess,
   SuperDiff::RSpec::Differs::CollectionContainingExactly,
   SuperDiff::RSpec::Differs::CollectionIncluding,
   SuperDiff::RSpec::Differs::HashIncluding,
   SuperDiff::RSpec::Differs::ObjectHavingAttributes,
   SuperDiff::Basic::Differs::Array,
   SuperDiff::Basic::Differs::Hash,
   SuperDiff::Basic::Differs::TimeLike,
   SuperDiff::Basic::Differs::DateLike,
   SuperDiff::Basic::Differs::MultilineString,
   SuperDiff::Basic::Differs::CustomObject,
   SuperDiff::Basic::Differs::DefaultObject]}
```
@mcmire mcmire enabled auto-merge (squash) April 25, 2024 18:01
@mcmire
Copy link
Copy Markdown
Collaborator

mcmire commented Apr 25, 2024

Oops! Thank you :)

@mcmire mcmire merged commit fc346d8 into splitwise:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants