Skip to content

feat(LENS-1390): add support for incremental catalog updates in Java SDK#120

Merged
samisayegh merged 6 commits into
mainfrom
feature/LENS-1390-support-incremental-stream
Feb 8, 2024
Merged

feat(LENS-1390): add support for incremental catalog updates in Java SDK#120
samisayegh merged 6 commits into
mainfrom
feature/LENS-1390-support-incremental-stream

Conversation

@jgwatkincoveo
Copy link
Copy Markdown
Contributor

Added the capability to use the stream mechanism in the Push API to enable incremental updates as per https://docs.coveo.com/en/l62e0540

@jgwatkincoveo jgwatkincoveo requested review from a team, sallainCoveo and samisayegh February 2, 2024 10:12
@jgwatkincoveo jgwatkincoveo changed the title LENS-1390 Java SDK supports incremental catalog updates (full fields) feat(LENS-1390): add support for incremental catalog updates in Java SDK Feb 2, 2024
Comment thread src/main/java/com/coveo/pushapiclient/StreamService.java
Comment thread src/main/java/com/coveo/pushapiclient/StreamServiceInternal.java Outdated
Comment thread src/main/java/com/coveo/pushapiclient/StreamServiceInternal.java Outdated
@louis-bompart louis-bompart self-requested a review February 5, 2024 15:55
Copy link
Copy Markdown
Contributor

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursive review, I mostly 👀 the public APIs for consistency sake for the users.
I leave the details of the implementation to y'all.

LGTM, double check the bump v with @y-lakhdar before merging

Comment thread pom.xml Outdated
Copy link
Copy Markdown

@samisayegh samisayegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ✅

Comment thread samples/UpdateStreamDocuments.java Outdated
Comment thread samples/UpdateStreamDocuments.java Outdated
Comment thread src/main/java/com/coveo/pushapiclient/StreamOperationType.java Outdated
Comment thread src/main/java/com/coveo/pushapiclient/StreamServiceInternal.java Outdated
Comment thread src/main/java/com/coveo/pushapiclient/StreamServiceInternal.java Outdated
Comment thread src/test/java/com/coveo/pushapiclient/StreamServiceInternalTest.java Outdated
Added new internal service to simplify and constrain the index operation types.
Version bump is automated by the release
@jgwatkincoveo
Copy link
Copy Markdown
Contributor Author

@y-lakhdar can you merge this in for me please as I'm not authorised to. Thanks.

@samisayegh samisayegh merged commit 7d172ad into main Feb 8, 2024
@samisayegh samisayegh deleted the feature/LENS-1390-support-incremental-stream branch February 8, 2024 15:20
This was referenced Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants